Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for the NodeClass is not a constructor issue #197

Merged

Conversation

segevfiner
Copy link
Contributor

If this was the real cause for the Jest failures, we can possibly restore those tests as well.

This isn't the prettiest way to handle this code wise, so feel free to suggest something cleaner, and note that I also had to handle it in CacheNodeForTree which would assert when it tries to cache a node during this state.

@verhovsky @amaanq

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants